Miscellaneous improvements in System #823
Conversation
terrajobst
added
the
netstandard-api
|
This is removing ISerializable from a bunch of exception types, what's the rationale for that? |
It was never intended to be on the derived types as the base type is implementing it. |
netstandard/ref/System.cs
Outdated
| @@ -89,7 +90,7 @@ public static partial class AppContext | |||
| public static void SetSwitch(string switchName, bool isEnabled) { } | |||
| public static bool TryGetSwitch(string switchName, out bool isEnabled) { isEnabled = default(bool); throw null; } | |||
| } | |||
| public sealed partial class AppDomain : System.MarshalByRefObject | |||
| public partial class AppDomain : System.MarshalByRefObject | |||
There was a problem hiding this comment.
What are the use cases for deriving from AppDomain? I don't see any problems with this from the Unity side, I'm just curious.
There was a problem hiding this comment.
Not sure. @weshaggard might know.
There was a problem hiding this comment.
This is a bug in .NET Core. AppDomain should have stayed sealed.
There was a problem hiding this comment.
Agreed I filed https://github.com/dotnet/corefx/issues/31391.
There was a problem hiding this comment.
I've fixed it here too
|
All feedback should be resolved. Are we ready? |
terrajobst
added
the
* NO MERGE *
|
@joshpeterson this is the only one you haven't signed off on. Oversight? 😄 Thanks! |
|
@terrajobst: Yes, I just missed it. Thanks! |
terrajobst
force-pushed
the
system-buffers
branch
from
6d7fc68
to
5597868
Compare
terrajobst
force-pushed
the
system
branch
2 times, most recently
from
7c39eaa
to
5b6e563
Compare
terrajobst
removed
the
* NO MERGE *
This also fixes #771 and fixed #539.
@dotnet/nsboard